Merged
Conversation
Member
Author
|
The php-src PR has been merged, and given that the current version we're shipping (5.7.3) has its tenth birthday soon, I think we should update for PHP 8.4, 8.5 and master. @shivammathur, if you agree, could you please merge and upload? |
Contributor
|
@cmb69 Done |
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built against PHP 8.3 and tested locally without noticing any issues (besides x86 builds are now level 1 warning clean).
Only minor issue is that apparently snmpd.pdb is no longer built, but I don't think a pdb for snmpd.exe is even relevant.
I suggest to roll this out to 8.4 and master, but only after php/php-src#15888 or a respective fix has been applied to php-src.