Merged
Conversation
12d6d69 to
2dedf19
Compare
2dedf19 to
dfa1668
Compare
Member
|
Thank you! This looks good to me. Note that there is PR #11 which added ARM64 support for MSVC16, likely somewhat differently. In my opinion, it is a bad idea to have separate solutions for different VS versions; at least nowadays there shouldn't be the need to have this. Still, for BC it might be best to stick with this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the project for Visual Studio 17 2022 and added the ARM64 configuration.
On ARM64 configuration, I have configured the
OutDirwith the same valeu fromx64and added the\binor\libfolder.To fix the linker warning MSB8012, I have removed the
\binor\libfolder on the output file configuration.I have also enabled
DYNAMICBASEto solveLINK : fatal error LNK1246: '/DYNAMICBASE:NO' not compatible with 'ARM64' target machine; link without '/DYNAMICBASE:NO'