docs: drop now-unreachable inline REFERENCES test-coverage entry#97
Merged
Conversation
PR #92 made inline column-level `REFERENCES` error at parse time (CAVEATS.md "Inline column-level REFERENCES is rejected"), so the third sub-bullet under "parseCreateTable column-loop interactions" — `inline REFERENCES × NOT NULL × ON UPDATE` — is no longer a reachable code shape. Drop the bullet, trim the buildFK reference from the parent description, and add a note explaining why the combination went away so the audit history stays legible. The other two sub-bullets (inline UNIQUE × DEFAULT, inline PK × column-level CHECK) are unaffected and still open. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 86.96% 86.96%
=======================================
Files 30 30
Lines 3321 3321
=======================================
Hits 2888 2888
Misses 266 266
Partials 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates TODO.md to reflect that inline column-level REFERENCES is now rejected at parse time (per PR #92), so one previously listed “parseCreateTable column-loop interaction” test-coverage item is no longer a reachable shape worth tracking.
Changes:
- Removes the now-unreachable “inline
REFERENCES × NOT NULL × ON UPDATE” sub-bullet from the test-coverage gap list. - Trims the parent description to remove the
buildFKmention, leavingapplyInlineColumnKeyas the relevant interaction point. - Adds an explanatory note and adjusts the test effort estimate to match the reduced scope.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #92 made inline column-level `REFERENCES` error at parse time (see CAVEATS.md "Inline column-level REFERENCES is rejected"), so the third sub-bullet under "parseCreateTable column-loop interactions" in TODO.md — `inline REFERENCES × NOT NULL × ON UPDATE` — is no longer a reachable code shape.
Changes
The other two sub-bullets (`inline UNIQUE × DEFAULT`, `inline PK × column-level CHECK`) are unaffected and still open.
Test plan
🤖 Generated with Claude Code