docs: trim completed test-coverage-audit items from TODO#91
Merged
Conversation
Five of the six items from the PR #84 postmortem audit landed: - composed-state catalog tests → PR #86 - kitchen-sink round-trip → PR #87 - emitter ordering pins → PR #88 - diff cross-cutting → PR #89 - directive composition → PR #90 Drop the closed items. Keep `parseCreateTable` column-loop interactions under "Medium — test coverage gaps" — that one was scoped out of the kitchen-sink because the open shapes (inline `UNIQUE × DEFAULT`, inline `REFERENCES × NOT NULL × ON UPDATE`, inline `PK × column-level CHECK`) need direct parser unit tests, not a round-trip fixture. The kitchen-sink uses `email VARCHAR NOT NULL UNIQUE` (no DEFAULT), an explicit named CONSTRAINT FK (not inline REFERENCES), and a table-level CHECK (not the column-level shape that exercises the vitess promotion path), so the gap is real. The "Medium — silent diffs / fidelity gaps" section keeps the real open items, including the three new ones surfaced by the audit itself (REFERENCES auto-name, vitess-keyword identifier drift, CHECK referencing renamed column). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 86.90% 86.90%
=======================================
Files 30 30
Lines 3277 3277
=======================================
Hits 2848 2848
Misses 263 263
Partials 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This doc-only PR trims TODO.md after the PR #84 follow-up work landed, leaving just the remaining open test-coverage item and moving it under a narrower heading. It keeps the TODO focused on current gaps rather than already completed audit work.
Changes:
- Remove the five completed entries from the former “Medium — test coverage audit” section.
- Rename the remaining section to “Medium — test coverage gaps”.
- Add brief rationale explaining why the surviving
parseCreateTablecoverage item still needs targeted unit tests instead of a round-trip fixture.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Estimated 8–12 catalog tests, half-day. Highest payoff per hour | ||
| because it directly targets the bug class that hit on PR #84. | ||
| The PR #84 postmortem audit closed five of its six items via PRs | ||
| \#86–#90; this one item was scoped out of the kitchen-sink fixture |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR #84 postmortem audit's "Medium — test coverage audit" section listed six items. Five landed via PRs #86–#90; one (
parseCreateTablecolumn-loop interactions) was scoped out of the kitchen-sink fixture because its specific shapes need direct unit tests rather than a round-trip DDL.The "Medium — silent diffs / fidelity gaps" section keeps its real open items, including the three new ones surfaced by the audit itself (inline REFERENCES auto-name, vitess-keyword identifier drift in generated columns, CHECK referencing renamed column blocks RENAME COLUMN).
Test plan
🤖 Generated with Claude Code