docs: drop YAML-harness-extension TODO item#78
Merged
Conversation
Most parser/diff tests assert on internal struct fields (e.g.
`tbl.Columns.GetOk("id"); assert.Equal("bigint", id.TypeName)`),
not on rendered SQL — a YAML harness for those would re-invent
Go's struct-literal/assertion DSL in YAML and end up more verbose,
not less. The CLAUDE.md rule already routes pure SQL-input →
SQL-output tests to YAML and keeps struct-shape tests in Go, so
the TODO was a generic "extend coverage" note that doesn't pay
off in practice.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates project documentation by removing a low-priority TODO item proposing a YAML test harness extension for parser/ and diff/, aligning the TODO list with the project’s existing testing guidance and practices.
Changes:
- Removed the TODO entry: “YAML harness extended to parser and diff (currently Go table tests).”
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 30 30
Lines 3237 3237
=======================================
Hits 2804 2804
Misses 267 267
Partials 166 166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO.md.parser/anddiff/tests assert on internal struct fields (e.g.tbl.Columns.GetOk("id"); assert.Equal("bigint", id.TypeName)), not on rendered SQL — a YAML harness there would re-invent Go's struct-literal / assertion DSL in YAML and end up more verbose, not less.Test plan
🤖 Generated with Claude Code