docs: document index-level KEY_BLOCK_SIZE gap, drop from TODO#102
Merged
Conversation
Decision: don't implement. Probing MySQL 8.0 turned up an important nuance the TODO entry missed — MySQL itself silently drops the per-index `KEY_BLOCK_SIZE` clause for InnoDB indexes. The clause is a MyISAM legacy with no effect on InnoDB, and neither `information_schema.STATISTICS` nor `SHOW CREATE TABLE` reflects the value back. So myschema's silent drop is consistent with MySQL's own behaviour; there's nothing to round-trip. CAVEATS.md gets a new "Index-level `KEY_BLOCK_SIZE=N` is silently dropped" section explaining the InnoDB-vs-MyISAM context. TODO.md drops the corresponding entry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the project documentation to explicitly record that per-index KEY_BLOCK_SIZE=N clauses don’t round-trip in myschema because MySQL itself drops them for InnoDB, and removes the corresponding open TODO item since it’s not actionable for MySQL 8.0+ InnoDB.
Changes:
- Added a new CAVEATS section explaining that index-level
KEY_BLOCK_SIZE=Nis silently dropped and why that matches MySQL behavior for InnoDB. - Removed the related TODO entry now that the limitation is documented and deemed non-actionable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
CAVEATS.md |
Documents that index-level KEY_BLOCK_SIZE=N is dropped (and why it’s not a myschema bug for InnoDB on MySQL 8.0+). |
TODO.md |
Removes the now-documented KEY_BLOCK_SIZE index-level gap from the open TODO list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 86.86% 86.86%
=======================================
Files 30 30
Lines 3357 3357
=======================================
Hits 2916 2916
Misses 270 270
Partials 171 171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decision: don't implement index-level `KEY_BLOCK_SIZE`. Probing MySQL 8.0 revealed that MySQL itself silently drops the per-index clause for InnoDB indexes — the syntax is a MyISAM legacy that InnoDB doesn't honour:
So myschema's silent drop matches MySQL's silent drop; there's no round-trip to fix.
Changes
Test plan
🤖 Generated with Claude Code