Skip to content

feat(window): add application menu and preserve window title#9

Merged
flexiondotorg merged 2 commits intomainfrom
window
Mar 21, 2026
Merged

feat(window): add application menu and preserve window title#9
flexiondotorg merged 2 commits intomainfrom
window

Conversation

@flexiondotorg
Copy link
Copy Markdown
Member

Summary

Improves the application window UI by adding an application menu system and preventing web content from overriding the application title. These changes enhance the desktop experience by establishing proper window control mechanisms and providing developers with accessible development tools.

Changes

  • Add persistent application title ('Sidra') to BrowserWindow configuration
  • Prevent web page title updates from overriding the window title via page-title-updated event handler
  • Import Menu from Electron and create platform-specific menu template
  • Add standard Edit menu and platform-specific App menu on macOS
  • Implement View menu with toggleDevTools when SIDRA_DEVTOOLS environment variable is set
  • Set application menu on window creation with informative log output

Testing

  • Verified window maintains 'Sidra' title when loading web content
  • Confirmed application menu appears on application launch
  • Tested dev tools toggle functionality in development environment
  • Validated platform-specific menu rendering (App menu on macOS only)

- Add 'Sidra' title to window configuration
- Prevent page-title-updated events from changing the window title

Signed-off-by: Martin Wimpress <code@wimpress.io>
- Import Menu from Electron
- Create platform-specific menu template with standard menus
- Add View menu with toggleDevTools for development environments
- Implement menu activation on window creation

Signed-off-by: Martin Wimpress <code@wimpress.io>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@flexiondotorg flexiondotorg merged commit 36235fb into main Mar 21, 2026
11 checks passed
@flexiondotorg flexiondotorg deleted the window branch March 21, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant