feat(widevine): add CastLabs EVS VMP signing and auto-generated release notes#5
Merged
flexiondotorg merged 4 commits intomainfrom Mar 21, 2026
Merged
feat(widevine): add CastLabs EVS VMP signing and auto-generated release notes#5flexiondotorg merged 4 commits intomainfrom
flexiondotorg merged 4 commits intomainfrom
Conversation
- Wrap LD_LIBRARY_PATH in Linux conditional; omit on macOS where standard FHS paths don't apply - Separate Linux-specific shellHook from cross-platform output - Add _fix-frameworks recipe to restore symlinks broken by extract-zip during npm install (affects Electron framework structure on macOS) - Include _fix-frameworks in build task to ensure frameworks are valid before TypeScript compilation Signed-off-by: Martin Wimpress <code@wimpress.io>
…M support - Add EVS VMP production signing via afterPack hook in electron-builder pipeline - Create macOS hardened runtime entitlements configuration - Update package.json to reference entitlements and afterPack hook - Configure GitHub Actions workflow to install uv and pass EVS credentials for CI - Use Linux Chrome UA on all platforms to bypass Apple's stricter DRM enforcement - Add local EVS signing command to Justfile - Include uv as Darwin-only devShell dependency in flake.nix Signed-off-by: Martin Wimpress <code@wimpress.io>
Add generate_release_notes: true to the action-gh-release step to automatically populate GitHub release notes with changelog entries. Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/builder.yml">
<violation number="1" location=".github/workflows/builder.yml:128">
P1: `uv` is only installed for macOS, but EVS signing uses `uvx` on Windows too. Install `uv` for Windows builds as well to avoid Windows packaging failures.</violation>
</file>
<file name="justfile">
<violation number="1" location="justfile:64">
P1: `install`/`build` now unconditionally depend on `_fix-frameworks` and `_sign-evs`, but those recipes are not defined for Windows, so Windows builds will fail.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
The setup-uv step was previously only run on macOS, but build/afterPack.cjs executes on both macOS and Windows for EVS VMP signing. Extend the condition to include Windows builds to avoid missing uv binary on Windows. Signed-off-by: Martin Wimpress <code@wimpress.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add CastLabs EVS VMP signing for macOS and Windows Widevine DRM support. Enable auto-generated release notes in GitHub Actions to automatically populate release descriptions from commits and pull requests.
Changes
afterPack.cjshook for code signing during build processentitlements.mac.plist)Testing
Related Issues
Closes #widevine-support