feat(theme): add Catppuccin colour scheme support with live toggle#19
Merged
flexiondotorg merged 3 commits intomainfrom Mar 22, 2026
Merged
feat(theme): add Catppuccin colour scheme support with live toggle#19flexiondotorg merged 3 commits intomainfrom
flexiondotorg merged 3 commits intomainfrom
Conversation
- Add Catppuccin CSS stylesheet with complete colour palette - Implement getCatppuccinEnabled() and setCatppuccinEnabled() config functions - Wire Catppuccin CSS injection on window load - Create applyCatppuccinCSS function for live enable/disable/variant changes - Add nativeTheme import for potential dark mode integration - Add i18n strings for Catppuccin theme labels - Update package.json with theme dependencies Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main.ts">
<violation number="1" location="src/main.ts:252">
P2: Serialize `applyCatppuccinCSS` calls; concurrent fire-and-forget updates can race and leave Catppuccin CSS in the wrong final state.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…ining - Wrap CSS injection/removal in sequential Promise chain - Prevents concurrent CSS operations from interfering with each other Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/main.ts">
<violation number="1" location="src/main.ts:254">
P1: A rejected CSS operation poisons the serialized promise chain, so all later Catppuccin toggles are skipped.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Add catch handler to log CSS operation failures - Ensure promise chain continues despite errors Signed-off-by: Martin Wimpress <code@wimpress.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist