ci(release): simplify workflow and use dynamic version from git tags#16
Merged
flexiondotorg merged 5 commits intomainfrom Mar 22, 2026
Merged
ci(release): simplify workflow and use dynamic version from git tags#16flexiondotorg merged 5 commits intomainfrom
flexiondotorg merged 5 commits intomainfrom
Conversation
Member
flexiondotorg
commented
Mar 22, 2026
- Replace manual version commit step with release existence validation
- Set package.json version to placeholder (0.0.0) since CI stamps version from git tag
- Reduces friction in release automation by removing unnecessary local commits
- Replace manual version commit step with release existence validation - Set package.json version to placeholder (0.0.0) since CI stamps version from git tag - Reduces friction in release automation by removing unnecessary local commits Signed-off-by: Martin Wimpress <code@wimpress.io>
Add credential validation before attempting VMP signing to prevent execution errors when EVS_ACCOUNT_NAME or EVS_PASSWD are not set. Signed-off-by: Martin Wimpress <code@wimpress.io>
Refactor version resolution to work for both tag and non-tag builds: - Replace npm version command with bash script for flexibility - Use git describe for fallback version on branch pushes - Maintain tag-based versioning when pushing tags Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/builder.yml">
<violation number="1" location=".github/workflows/builder.yml:139">
P1: Non-tag builds can generate a non-semver `VERSION` from `git describe`, causing `npm version` to fail and break CI builds.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Use `git describe --tags --abbrev=0` for cleaner tag output - Strip leading 'v' prefix from version string - Add fallback to "0.0.0-dev" when no tags exist - Simplifies version handling on non-tag builds Signed-off-by: Martin Wimpress <code@wimpress.io>
- Add fetch-depth: 0 to actions/checkout for full history - Replace multi-line bash conditional with simpler git describe command - Use echo fallback for missing tags instead of explicit if-block Signed-off-by: Martin Wimpress <code@wimpress.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.