refactor: simplify codebase and optimise splash loading#14
Merged
flexiondotorg merged 4 commits intomainfrom Mar 22, 2026
Merged
refactor: simplify codebase and optimise splash loading#14flexiondotorg merged 4 commits intomainfrom
flexiondotorg merged 4 commits intomainfrom
Conversation
…eming - Move `pkg` require to module level in i18n.ts and tray.ts to prevent duplicate requires - Add complete Theming section to SPECIFICATION.md with Catppuccin palette details - Document CSS injection mechanism and dark/light mode variants - List SEND_CHANNELS explicitly in preload.ts for clarity; add context comment - Update out-of-scope section to clarify no custom UI or plugin systems supported Signed-off-by: Martin Wimpress <code@wimpress.io>
- Extract chromeUA() result to variable for reuse across main.ts - Consolidate redundant locale resolution logic in i18n.ts - Remove unused RECEIVE_CHANNELS and IPC listener validation in preload.ts Signed-off-by: Martin Wimpress <code@wimpress.io>
- Add getSystemLanguages() to cache app.getPreferredSystemLanguages() - Extract getLocalizedEntry() to consolidate language resolution logic - Parallelise Widevine CDM init with service worker cache clearing - Move cache clearing before window loading to avoid stale responses - Restrict User-Agent header rewriting to music.apple.com requests only - Update splash screen assets and apply optimisations - Add splash.png asset - Refactor main.ts preload setup for clarity Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/SPECIFICATION.md">
<violation number="1" location="docs/SPECIFICATION.md:490">
P3: The theming persistence sentence is internally inconsistent: it says no restart is required, but also says changes apply on next launch.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
The theme preference change now requires application restart rather than being applied on next launch. Signed-off-by: Martin Wimpress <code@wimpress.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored application startup to streamline code structure, optimise splash screen loading, and remove unused definitions. Improved icon assets with reduced file sizes.
Changes
Testing
Related Issues
None