Conversation
The `ForbiddenGlobalVariableVariable` sniff was a little overzealous and would throw errors for valid variable variables.
The sniff has now been partially refactored.
The following improvements were made:
* Don't throw errors for non-complex variable variables. Issue 537.
* Correctly handle variable variables with whitespace or comments within the variable.
* Throw an `error` for *each* forbidden variable. Previously only one error would be thrown per `global` statement.
- The error is now thrown on the line containing the variable, not the line containing the `global` keyword.
- The error message now shows the problem variable encountered.
* Throw a `warning` for non-bare variables encountered in a `global` statement.
- This warning has a separate errorcode allowing for easy exclusion.
- The warning, like the error, will show the problem variable encountered.
The unit tests have been redone to account for these changes.
Fixes 537
wimg
approved these changes
Dec 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ForbiddenGlobalVariableVariablesniff was a little overzealous and would throw errors for valid variable variables.The sniff has now been partially refactored.
The following improvements were made:
errorfor each forbidden variable. Previously only one error would be thrown perglobalstatement.globalkeyword.warningfor non-bare variables encountered in aglobalstatement.The unit tests have been redone to account for these changes.
Fixes #537
@wimg If needed, the warning can be taken out quite easily. Let me know if you don't want it in the sniff.