Skip to content

Readme: Improve grammar of the reporting information#552

Merged
wimg merged 1 commit intomasterfrom
feature/fix-grammer
Dec 25, 2017
Merged

Readme: Improve grammar of the reporting information#552
wimg merged 1 commit intomasterfrom
feature/fix-grammer

Conversation

@jrfnl
Copy link
Copy Markdown
Member

@jrfnl jrfnl commented Dec 23, 2017

The same message was now shown twice, with one still containing a typo.

This PR moves the message out of the installation instructions, to the readme section on running PHPCompatibility.
It also improves the grammer of the text.

@jrfnl jrfnl added this to the 8.1.0 milestone Dec 23, 2017
@jrfnl jrfnl requested a review from wimg December 23, 2017 05:46
README.md Outdated
- You can run the checks for just one specific PHP version by adding `--runtime-set testVersion 5.5` to your command line command.
- You can also specify a range of PHP versions that your code needs to support. In this situation, compatibility issues that affect any of the PHP versions in that range will be reported: `--runtime-set testVersion 5.3-5.5`.
- As of PHPCompatibility 7.1.3, you can omit one part of the range if you want to support everything above or below a particular version, i.e. use `--runtime-set testVersion 7.0-` to run all the checks for PHP 7.0 and above.
* By default the report will be send to the console, if you want to save the report to a file, add the following to the command line command: `--report-full=path/to/report-file`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'will be sent'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up the existing commit.

The same message was now shown twice, with one still containing a typo.

This PR moves the message out of the installation instructions, to the readme section on running PHPCompatibility.
It also improves the grammer of the text.
@jrfnl jrfnl force-pushed the feature/fix-grammer branch from 1775c4a to 36c0ceb Compare December 24, 2017 15:20
@wimg wimg merged commit 8b1ad15 into master Dec 25, 2017
@wimg wimg deleted the feature/fix-grammer branch December 25, 2017 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants