Merged
Conversation
The PHP-Coveralls project has *finally* tagged some releases. Using the tagged versions allows Travis to cache the package download which should hopefully make the builds a little faster. The minimum PHP version for v 2.x is PHP 5.5, for the 1.x branch, it's PHP 5.3.3, so depending on the build, different versions are being used. Other notes: * The repository has moved from `satooshi/php-coveralls` to `php-coveralls/php-coveralls`. * As of PHPCoveralls 2.x, the command to call coveralls has changed from `coveralls` to `php-coveralls` This PR takes all of the above into account. Keeping my fingers crossed that the build will pass & coverage will be reported correctly (again). Fixes 549
Coveralls is run against the highest and the lowest PHP version to get the best results. As PHP 7.2 has been released, the highest PHP version is now 7.2
Member
Author
|
Ok, just checked the Travis logs, but apparently it's still not working. |
Member
Author
|
Found it & fixed it! |
wimg
approved these changes
Dec 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP-Coveralls project has finally tagged some releases. Using the tagged versions allows Travis to cache the package download which should hopefully make the builds a little faster.
The minimum PHP version for v 2.x is PHP 5.5, for the 1.x branch, it's PHP 5.3.3, so depending on the build, different versions are being used.
Other notes:
satooshi/php-coverallstophp-coveralls/php-coveralls.coverallstophp-coverallsThis PR takes all of the above into account. Keeping my fingers crossed that the build will pass & coverage will be reported correctly (again).
Fixes #549 (hopefully... let's see if it really did after the build has run)