Merged
Conversation
New sniff to detect dynamic access to static methods and properties, as well as class constants, prior to PHP 5.3. Includes unit tests. We may run into some false positives, though I've done due diligence and ran the sniff over a couple of semi-large PHP projects with various minimum PHP requirements (WordPress (5.2), PHP_CodeSniffer (5.4), PHPUnit 6.x (7.0) ) to see if could find any and so far, I haven't. Fixes 534
wimg
approved these changes
Nov 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New sniff to detect dynamic access to static methods and properties, as well as class constants, prior to PHP 5.3.
Includes unit tests.
We may run into some false positives, though I've done due diligence and ran the sniff over a couple of semi-large PHP projects with various minimum PHP requirements (WordPress (5.2), PHP_CodeSniffer (5.4), PHPUnit 6.x (7.0) ) to see if could find any and so far, I haven't.
Fixes #534