Looks like it's failing on 2 builds ?

Two on the PR build, three on the push build. Hmm... Those failures don't have anything to do with the change in this PR, but might well be related to more changes in the Travis PHP images.

I've changed the PHP 5.4 builds back to using trusty for those two builds - they needed precise in Q2. Finger crossed this will fix it.

Right. Finally took the time to try & figure out what is going on here.

I've traced the errors back to the PHPUnit version being used for those builds. Specifically to a change made in PHPUnit 4.6.0 which is when the builds start breaking in combination with PHP 5.3 and 5.4 and older PHPCS versions.
Running PHPCS manually with the specific version combinations over the test files which fail in the unit test run, yield the correct results, so it's not PHPCS failing, but something in the BaseSniffTest class in combination with certain PHPUnit versions.

The relevant current Travis images use:

Strangely enough the build for PHP 5.4 / PHPCS 3.x, both for the old as well as for the new images, seems to have been run on 5.4.45/4.8.35 and passes without issue (confirming that it is something in the BaseSniffTest class).

Sadly, I've not been able to track down which specific change in PHPUnit is the one causing the problem and have therefore not been able to figure out a way to mitigate this. I suspect it has something to do with the command line options being passed to PHPCS and PHPUnit getting confused over it, but debugging this has so far not yielded any results.

What I'd like to propose is to just fix the PHPUnit version for the 3 affected builds to PHPUnit 4.5.1 and be done with it. At least that way the builds will pass again and new PRs can be pulled.

Refs:

• https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-4.6.0
• https://github.com/sebastianbergmann/phpunit/blob/4.6/ChangeLog-4.6.md#phpunit-460

Given that HHVM is no longer supported by any of the big frameworks, should we keep support for it at all ?

Given that HHVM is no longer supported by any of the big frameworks, should we keep support for it at all ?

I'm ambivalent about it. Basically as long as we don't need to do any extra coding in the sniffs for the builds to pass, I'm happy enough to leave it be. It can help devs who dev on HHVM, but deploy to PHP.
Having said that, as I'm not one of them, I'm easily swayed to drop it 😉

@wimg What should the milestone for this one be ? 8.0.2 or 8.1.0 ?