add language filter#48
Closed
alikon wants to merge 1 commit intowilsonge:feature/content-improvementsfrom
alikon:patch-112
Closed
add language filter#48alikon wants to merge 1 commit intowilsonge:feature/content-improvementsfrom alikon:patch-112
alikon wants to merge 1 commit intowilsonge:feature/content-improvementsfrom
alikon:patch-112
Conversation
Owner
|
So I'd deliberately left this one out because it's not the primary attribute of the Resource and I wasn't sure if it should be (i.e. we should filter on the content type primary key as opposed to language code) |
Author
|
i was testing on a multiligual so i've thinked at it like a missed option.... but yeah let's focus on porting filter on all the core component before |
Owner
|
It's definitely missing and needs to be there before stable. but probably needs a proper discussion |
Author
|
ok i'll do a new pr |
Owner
|
thankyou :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
added language filter
Testing Instructions
JROOT_URL/api/index.php/v1/content/article?filter[language]=de-DEExpected result
filter by language
Actual result
Documentation Changes Required