Skip to content

add language filter#48

Closed
alikon wants to merge 1 commit intowilsonge:feature/content-improvementsfrom
alikon:patch-112
Closed

add language filter#48
alikon wants to merge 1 commit intowilsonge:feature/content-improvementsfrom
alikon:patch-112

Conversation

@alikon
Copy link
Copy Markdown

@alikon alikon commented Mar 20, 2020

Pull Request for Issue # .

Summary of Changes

added language filter

Testing Instructions

JROOT_URL/api/index.php/v1/content/article?filter[language]=de-DE

Expected result

filter by language

Actual result

Documentation Changes Required

@wilsonge
Copy link
Copy Markdown
Owner

So I'd deliberately left this one out because it's not the primary attribute of the Resource and I wasn't sure if it should be (i.e. we should filter on the content type primary key as opposed to language code)

@alikon
Copy link
Copy Markdown
Author

alikon commented Mar 20, 2020

i was testing on a multiligual so i've thinked at it like a missed option.... but yeah let's focus on porting filter on all the core component before

@wilsonge
Copy link
Copy Markdown
Owner

It's definitely missing and needs to be there before stable. but probably needs a proper discussion

@alikon
Copy link
Copy Markdown
Author

alikon commented Mar 20, 2020

ok i'll do a new pr

@alikon alikon closed this Mar 20, 2020
@alikon alikon deleted the patch-112 branch March 20, 2020 11:14
@wilsonge
Copy link
Copy Markdown
Owner

thankyou :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants