Add fallback support for when cURL multi is not available#17
Add fallback support for when cURL multi is not available#17westonruter wants to merge 5 commits intowillwashburn:masterfrom
Conversation
|
@willwashburn Are unit tests on CI not working? |
|
I ran the unit tests locally and they are working when |
willwashburn
left a comment
There was a problem hiding this comment.
Awesome quick work @westonruter ! Always impressed at how quickly you move on this stuff. Only a few suggestions so we can get it all tested and documented.
I'm not sure why Circle isn't running your branch, as it seems to be running when I tired last:
https://circleci.com/gh/willwashburn/fasterimage/33
Perhaps it only runs on my branches?
Also, it seems like this repo might be important to things you work on frequently. Would you like some higher level of commit access here so I am not a risk of blocking you in the future?
Co-Authored-By: Will Washburn <will.washburn@gmail.com>
|
If you'd like to add me as a pusher to the repo that would be great. Hopefully that would also cause Circle to get triggered. |
|
Ah, Circle is now running the tests from my PR. It may be that I had to be added as a contributor first. |
|
@willwashburn Circle is failing with apparently due to the update of PHPUnit from v4 to v6. Perhaps a Composer cache problem? |
|
@willwashburn could you please try the “Rebuild without cache”?
(I would but there are auth issues for me with GitHub and Circle.) |
|
@westonruter I tried rerunning without the cache but doesn't even seem to be getting there. I think if you make another commit it might actually run (circle is weird) |
|
(I had to also push the commit to a branch on the target repo in order to trigger the build.) |
|
Closing in favor of #18. |
Fixes #16.
This PR modifies
FasterImage::batch()to check if cURL multi is available, and if not, it falls back to doing plaincurl_init()calls to obtain the images sequentially.