chore: updated by review tips#15
Merged
will-2012 merged 12 commits intoperf-trienode-readfrom Jun 12, 2024
Merged
Conversation
d7fd7a5 to
0d229af
Compare
will-2012
commented
Jun 11, 2024
triedb/pathdb/difflayer.go
Outdated
| } | ||
| diffHashCacheLengthGauge.Update(int64(h.length())) | ||
| log.Debug("Add difflayer to hash map", "root", ly.rootHash(), "map_len", h.length()) | ||
| log.Info("Add difflayer to hash map", "root", ly.rootHash(), "block_number", dl.block, "map_len", h.length(), "add_delta", h.length()-beforeAdd) |
will-2012
commented
Jun 11, 2024
triedb/pathdb/difflayer.go
Outdated
| } | ||
| diffHashCacheLengthGauge.Update(int64(h.length())) | ||
| log.Debug("Remove difflayer from hash map", "root", ly.rootHash(), "map_len", h.length()) | ||
| log.Info("Remove difflayer from hash map", "root", ly.rootHash(), "block_number", dl.block, "map_len", h.length(), "del_delta", beforeDel-h.length()) |
will-2012
commented
Jun 11, 2024
triedb/pathdb/layertree.go
Outdated
| tree.lock.Lock() | ||
| defer tree.lock.Unlock() | ||
|
|
||
| defer func() { |
will-2012
commented
Jun 11, 2024
triedb/pathdb/layertree.go
Outdated
| for root, layer := range tree.layers { | ||
| if dl, ok := layer.(*diskLayer); ok && dl.isStale() { | ||
| remove(root) | ||
| log.Info("Remove stale the disklayer", "disk_root", dl.root.String()) |
28bcfe0 to
8e6e681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: