[WFLY-21044]: Not recovered transactions after crash of server with MDB.#19303
[WFLY-21044]: Not recovered transactions after crash of server with MDB.#19303bstansberry merged 3 commits intowildfly:mainfrom
Conversation
MDB. * Fixing how WildFly provides the recovery manager to Artemis * Removing the old MSC API usage to get the RecoveryService Jira: https://issues.redhat.com/browse/WFLY-21044 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
* Upgrading Artemis from 2.42 to 2.43.0. * release Note: https://activemq.apache.org/components/artemis/download/release-notes-2.43.0 Jira: https://issues.redhat.com/browse/WFLY-21063 Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
|
I can confirm this PR is fixing WFLY-21044 and does not cause any regression in messaging. |
|
Is the Artemis update required for the bug fix? If not it's better if they are decoupled. |
bstansberry
left a comment
There was a problem hiding this comment.
After chatting with @ehsavoie I don't object to combining the upgrade with this; I don't think it will delay merging.
But, I suspect the MSC bits need to be ported to 38.x while a minor update or Artemis needs more thought there. So there I suggest separating things.
I've got a minor code review comment though. Sorry; I meant to post that yesterday.
| @@ -38,9 +34,6 @@ private static XAResourceRecoveryRegistry getXAResourceRecoveryRegistry() { | |||
| // This parsing isn't 100% ideal as it's somewhat 'internal' knowledge of the relationship between | |||
| // capability names and service names. But at this point that relationship really needs to become | |||
| // a contract anyway | |||
There was a problem hiding this comment.
The comment lines should be removed since they are no longer relevant.
#19304 is the backport to 38.x (without the artemis upgrade) |
bstansberry
left a comment
There was a problem hiding this comment.
I added a commit to get rid of the comment.
I don't care about that nit in the 38.x PR; it's just cruft cleanup.
|
Thanks @ehsavoie |
Jira: https://issues.redhat.com/browse/WFLY-21044
https://issues.redhat.com/browse/WFLY-21063