Fix for WFLY-19989, h2-driver layer rule for jakarta DataSourceDefinition annotation#18420
Merged
bstansberry merged 1 commit intowildfly:mainfrom Nov 26, 2024
Merged
Fix for WFLY-19989, h2-driver layer rule for jakarta DataSourceDefinition annotation#18420bstansberry merged 1 commit intowildfly:mainfrom
bstansberry merged 1 commit intowildfly:mainfrom
Conversation
Contributor
Author
|
Failure is caused by WildFly Glow, preparing a fix and a 1.2.0.Beta2. |
bstansberry
reviewed
Nov 26, 2024
|
|
||
| import jakarta.annotation.sql.DataSourceDefinition; | ||
|
|
||
| @DataSourceDefinition(name = "x", className = "org.h2.jdbcx.JdbcDataSource") |
Contributor
There was a problem hiding this comment.
How about another class that uses the url attribute?
Contributor
|
@jfdenise I'm going to merge this but I think adding a test of the url attribute would be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/WFLY-19989
This fix is expected by quickstart: wildfly/quickstart#973