Rename fields when generating map encodings#46
Open
hannahhoward wants to merge 1 commit intowhyrusleeping:masterfrom
Open
Rename fields when generating map encodings#46hannahhoward wants to merge 1 commit intowhyrusleeping:masterfrom
hannahhoward wants to merge 1 commit intowhyrusleeping:masterfrom
Conversation
if a struct field has a tag with key "json", use that in generating a map encoder as opposed to the var name --> allows field renames on map encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Allow using keys other than the actual field name when generating map encodings.
Implementation
If a struct field has a tag with key "json", use that as the "name" for the field when generating a map encoder as opposed to the actual field's name. (otherwise just use the name)
This has a number of potential uses: