Handle Nil values for cbg.Deferred#14
Merged
whyrusleeping merged 1 commit intowhyrusleeping:masterfrom Apr 2, 2020
Merged
Conversation
add a self check for nil in cbg.Deferred. Also add an error check for Deferred.Raw = nil which causes an error on unmarshal
Contributor
Author
|
@whyrusleeping can you merge it? I don't have access :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Handle two unusual cases for a cbg.Deferred value in the Marshalling process
Implementation
Resolution: add a self nil check in the Marshall method for *cbg.Deferred and write a cbor.Null
Resolution: this shouldn't happen. It means you forgot to serialize the deferred value into Raw. Moreover, currently it produces unpredictable behavior because Marshall will succeed (writing nothing), but then nothing is written to the buffer so if a Deferred is in a struct, the immediate proceeding field will likely have an unpredictable error, as it's data will be read into Raw on Unmarshal. Instead, return error on Marshal for this case.