Add .otc support, fix invalid .ttc/.otc handling and update readme.md to match the new features.#9
Merged
whtsky merged 5 commits intowhtsky:masterfrom Mar 24, 2021
Zopolis4:master
Merged
Add .otc support, fix invalid .ttc/.otc handling and update readme.md to match the new features.#9whtsky merged 5 commits intowhtsky:masterfrom Zopolis4:master
whtsky merged 5 commits intowhtsky:masterfrom
Zopolis4:master
Conversation
Causes the script to print an error message and then continue when the script encounters a broken .ttc file.
Allows the script to unpack .otc files (resulting fonts are .ttf)
The script no longer changes .otf files extracted from .otc to .ttf
whtsky
requested changes
Mar 23, 2021
Owner
whtsky
left a comment
There was a problem hiding this comment.
Sorry for the late review. The changes look good overall.
whtsky
approved these changes
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for unpacking .otc files. It also causes the script to print an error message and then continue when the script encounters a broken .ttc/.otc file. Previously, when the script encountered an invalid .ttc/.otc file it would refuse to parse any of the files in the directory. It also updates the readme.md to include the new features added in the PR.