Skip to content

Support preconnect in link headers & early hints#7835

Merged
domenic merged 5 commits into
whatwg:mainfrom
noamr:preconnect-header
Apr 26, 2022
Merged

Support preconnect in link headers & early hints#7835
domenic merged 5 commits into
whatwg:mainfrom
noamr:preconnect-header

Conversation

@noamr

@noamr noamr commented Apr 19, 2022

Copy link
Copy Markdown
Contributor

(See WHATWG Working Mode: Changes for more details.)


/links.html ( diff )
/semantics.html ( diff )

@noamr noamr changed the title Allow preconnect in link headers & early hints Support preconnect in link headers & early hints Apr 19, 2022
@bashi

bashi commented Apr 20, 2022

Copy link
Copy Markdown

Thank you for working on this! You may want to refer to https://crbug.com/1245107 for Chrome implementation bug.

@domenic domenic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we/can we have any non-early hints tests?

Comment thread source
Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
@noamr

noamr commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

Do we/can we have any non-early hints tests?

We cannot so far. The problem is that the browser keeps a connection pool anyway, so in many situations in WPT connecting will take 0 time anyway and preconnect would not have any effect. Still trying to think of a way to generate a fresh connection behavior in the WPT context and open to suggestions...

I feel that connection pools, DNS etc need a different testing environment than WPT.

Comment thread source Outdated
Comment thread source Outdated

@domenic domenic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more issue. Be sure to pull and rebase before doing so as I was doing the final rewrapping/nit pass while I found it :)

Comment thread source Outdated
@domenic domenic merged commit d4115a1 into whatwg:main Apr 26, 2022
@noamr noamr deleted the preconnect-header branch April 26, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants