Support preconnect in link headers & early hints#7835
Merged
Conversation
|
Thank you for working on this! You may want to refer to https://crbug.com/1245107 for Chrome implementation bug. |
Contributor
Author
We cannot so far. The problem is that the browser keeps a connection pool anyway, so in many situations in WPT connecting will take 0 time anyway and preconnect would not have any effect. Still trying to think of a way to generate a fresh connection behavior in the WPT context and open to suggestions... I feel that connection pools, DNS etc need a different testing environment than WPT. |
domenic
reviewed
Apr 25, 2022
domenic
reviewed
Apr 26, 2022
domenic
left a comment
Member
There was a problem hiding this comment.
I found one more issue. Be sure to pull and rebase before doing so as I was doing the final rewrapping/nit pass while I found it :)
domenic
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
/links.html ( diff )
/semantics.html ( diff )