Skip to content

Export 'the directionality' for Element#6676

Closed
marcoscaceres wants to merge 2 commits intowhatwg:mainfrom
marcoscaceres:directionality
Closed

Export 'the directionality' for Element#6676
marcoscaceres wants to merge 2 commits intowhatwg:mainfrom
marcoscaceres:directionality

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 12, 2021

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So https://notifications.spec.whatwg.org/ has no such defaulting. I'm a bit worried that folks might not set the direction on the document element consistently enough and it only works for APIs that have a document nearby. Wouldn't it be better to force this to be set for all APIs (defaulting to "auto") so people know what to do and what to expect?

source Outdated
<hr>

<p><dfn>The directionality</dfn> of an element (any element, not just an <span data-x="HTML
<p><dfn export for="Element">The directionality</dfn> of an element (any element, not just an <span data-x="HTML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wrap at a 100 columns on spaces.

@marcoscaceres
Copy link
Member Author

So https://notifications.spec.whatwg.org/ has no such defaulting.

True, and it applies to both the notification's body and the title.

I'm a bit worried that folks might not set the direction on the document element consistently enough and it only works for APIs that have a document nearby.

Agree.

Wouldn't it be better to force this to be set for all APIs (defaulting to "auto") so people know what to do and what to expect?

Personally, I think it's better to do it the way it's done in Notifications, by having it set explicitly in by the API.

I'm going to see if Payment Request can get away without having the explicit direction in "v1", then we can add the explicit direction for each localizable member (or a default base direction).

Related w3c/string-meta#54 and whatwg/webidl#358

@domenic
Copy link
Member

domenic commented Jun 23, 2021

If I am reading w3c/payment-request#956 right this is no longer needed. Please let us know if I misunderstood though!

@domenic domenic closed this Jun 23, 2021
@marcoscaceres marcoscaceres deleted the directionality branch June 25, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants