Remove image/media origins and check origin-cleanness directly#6656
Merged
Remove image/media origins and check origin-cleanness directly#6656
Conversation
That is, check the type of response directly, instead of synthesizing an opaque origin for opaque responses and then comparing that to the entry settings object's origin. This helps with #1431 by removing various uses of the entry concept, and closes #2761 by removing the origin concept for image and media elements entirely, since it is now unused.
31 tasks
annevk
approved these changes
May 6, 2021
Member
annevk
left a comment
There was a problem hiding this comment.
This is amazing. I'm surprised it ended up being such a straightforward patch.
Note that this is also fixes #2813. And given that @jakearchibald might want to look at this or cheer or some such. 😊
source
Outdated
| <span>CORS-same-origin</span> or <span>CORS-cross-origin</span>; this affects the | ||
| <span>origin</span> of the image itself (e.g., when used on a <code>canvas</code>).</p></li> | ||
| <span>CORS-same-origin</span> or <span>CORS-cross-origin</span>; this affects the image's | ||
| interaction with other APIs (e.g. when used on a <code>canvas</code>).</p></li> |
Collaborator
|
Yessssss! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is, check the type of response directly, instead of synthesizing an opaque origin for opaque responses and then comparing that to the entry settings object's origin.
This helps with #1431 by removing various uses of the entry concept, and closes #2761 by removing the origin concept for image and media elements entirely, since it is now unused.
(See WHATWG Working Mode: Changes for more details.)
/canvas.html ( diff )
/imagebitmap-and-animations.html ( diff )
/images.html ( diff )
/origin.html ( diff )