Remove entry settings object usage in the WebSocket constructor#6655
Merged
Remove entry settings object usage in the WebSocket constructor#6655
Conversation
This matches implementations, and helps with #1431. Also, slightly modernize the algorithm.
31 tasks
annevk
approved these changes
May 6, 2021
source
Outdated
|
|
||
| <p>The <dfn constructor for="WebSocket"><code data-x="dom-WebSocket">WebSocket(<var>url</var>, | ||
| <var>protocols</var>)</code></dfn> constructor, when invoked, must run these steps:</p> | ||
| <p>The <dfn constructor for="WebSocket"><code data-x="dom-WebSocket">new WebSocket(<var>url</var>, |
Member
There was a problem hiding this comment.
For Bikeshed you'd have to add lt="WebSocket(url, protocols)". (Otherwise it wouldn't be able to find this from the IDL.)
Member
Author
There was a problem hiding this comment.
Wattsi disallows lt="" on <dfn> right now :(. I think maybe we should have Wattsi or Bikeshed be smarter about this case, e.g. Wattsi could generate lt="" when the existing text starts with new, or Bikeshed could learn about this style.
Member
There was a problem hiding this comment.
We used data-lt="" elsewhere, but I also agree with that.
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches implementations, and helps with #1431.
Also, slightly modernize the algorithm.
(See WHATWG Working Mode: Changes for more details.)
/cc @ricea
/web-sockets.html ( diff )