Use "credentials mode" instead of "CORS setting" for modules#607
Merged
Use "credentials mode" instead of "CORS setting" for modules#607
Conversation
This is a purely editorial update. We have essentially two types representing the credentials mode. Previously we used the CORS setting type up until the last minute, where we converted it into a credentials mode. This ends up being inconvenient for worker-modules, so instead we now convert from CORS setting to credentials mode up front and use that throughout.
Merged
Member
|
Quick scan suggests LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a purely editorial update. We have essentially two types
representing the credentials mode. Previously we used the CORS setting
type up until the last minute, where we converted it into a credentials
mode. This ends up being inconvenient for worker-modules, so instead we
now convert from CORS setting to credentials mode up front and use that
throughout.