Closed
Conversation
Member
|
I'm not sure I support the use case. Other APIs, e.g., the notification API, have no such defaulting and have explicit support for language annotation. And especially for the |
Member
|
Yeah, I agree - @annevk raises a good point. I don't think anyone implements this anyway, so I think we should remove this from payment request, and look at how the Notification API does the explicit language opt-in. |
Contributor
Author
|
Thanks @annevk, we will fix the Payment request spec! Also thanks @marcoscaceres for explaining @annevk's comment to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I'd like to export
the body elementso that the payment request spec can reference it with xref. The spec references it here.I added a
data-dfn-for="document"becausethe body elementseems like a generic term that might be used somewhere else. It is likely that we don't want this to be the 'default' definition forthe body element. Learning from reviewers' explanations in my earlier PR here.Note: There is another already-exported definition of
bodyhere. However, @marcoscaceres confirmed that payment spec wants to link to this particular definition ofthe body elementThank you!
cc @marcoscaceres
/dom.html ( diff )