Skip to content

Add DWeb protocols to the safelist#3936

Open
lidel wants to merge 1 commit intowhatwg:mainfrom
lidel:safelist-dweb-protocols
Open

Add DWeb protocols to the safelist#3936
lidel wants to merge 1 commit intowhatwg:mainfrom
lidel:safelist-dweb-protocols

Conversation

@lidel
Copy link
Copy Markdown

@lidel lidel commented Aug 17, 2018 •
edited by pr-preview bot
Loading

This PR closes #3935 by adding ssb, dat, ipfs, ipns and dweb protocols to the safelist of HTML spec.

See #3935 for motivation and updates on current vendor support.

💥 Error: Wattsi server error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:59 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.

🔗 Related URL

<html>
<head><title>504 Gateway Time-out</title></head>
<body bgcolor="white">
<center><h1>504 Gateway Time-out</h1></center>
<hr><center>nginx/1.10.3</center>
</body>
</html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@domenic domenic added the addition/proposal New features or enhancements label Aug 17, 2018
domenic
domenic approved these changes Aug 17, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given the implementation status: already implemented in Firefox, and with support from Chromium.

I'll wait a bit to merge so anyone else can chime in, but I'm excited that we finally have the implementer interest to unblock these sorts of requests from developers :D.

@annevk
Copy link
Copy Markdown
Member

annevk commented Aug 18, 2018

What's our testing story here?

@lidel
Copy link
Copy Markdown
Author

lidel commented Aug 18, 2018

Pass when navigator.registerProtocolHandler is able to register web-based handler for the safelisted protocol. Fail when browser refuses to register it (example).

@annevk
Copy link
Copy Markdown
Member

annevk commented Aug 20, 2018

Sorry for being vague, I meant in terms of wpt. I guess tests can be added that assert there's no exception at least.

@domenic domenic added the needs tests Moving the issue forward requires someone to write tests label Aug 21, 2018
@domenic
Copy link
Copy Markdown
Member

domenic commented Aug 21, 2018

We should also be able to add tests that the protocol handler given gets used, I think? E.g. by clicking on an appropriate link? So yeah, we need tests before we can merge this.

@asankah, when you implement this perhaps you could include some web platform tests?

@asankah
Copy link
Copy Markdown
Contributor

asankah commented Aug 21, 2018

Yup. I'll add tests for the whitelisted schemes.

Base automatically changed from master to main January 15, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenic domenic domenic approved these changes

Assignees

No one assigned

Labels

addition/proposal New features or enhancements needs tests Moving the issue forward requires someone to write tests topic: custom protocols

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Safelist protocol handlers for DWeb

4 participants

@lidel @annevk @domenic @asankah