Revamp base URL change processing#11442
Merged
Merged
Conversation
This removes the dependency on two concepts supposedly defined in DOM, that have not existed for many years. Instead, we have HTML directly call into the new "respond to base URL changes" steps, when mutations happen to a Document that would cause the base URL to change. Also reorganizes some of the base URL stuff to stick together, instead of being mixed between "Dynamic changes to base URLs" and "Terminology". Closes whatwg/dom#61.
This was referenced Jul 9, 2025
annevk
approved these changes
Jul 22, 2025
annevk
left a comment
Member
There was a problem hiding this comment.
Very nice, thanks for tackling this longstanding issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency on two concepts supposedly defined in DOM, that have not existed for many years. Instead, we have HTML directly call into the new "respond to base URL changes" steps, when mutations happen to a Document that would cause the base URL to change.
Also reorganizes some of the base URL stuff to stick together, instead of being mixed between "Dynamic changes to base URLs" and "Terminology".
Closes whatwg/dom#61.
Removing the PR template as this is mostly a bug fix. Checking that there's some test coverage for
:visitedchanges might be good, but I'd prefer not to block this PR on it./browsing-the-web.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/semantics.html ( diff )
/urls-and-fetching.html ( diff )