Remove exception reporting from declarative shadow dom#10552
Merged
domenic merged 4 commits intowhatwg:mainfrom Aug 14, 2024
Merged
Remove exception reporting from declarative shadow dom#10552domenic merged 4 commits intowhatwg:mainfrom
domenic merged 4 commits intowhatwg:mainfrom
Conversation
See whatwg#10527 for context, but no browser currently reports exceptions for this case, and doing so might pose an XSS risk. Correct the spec text accordingly. Closes whatwg#10527
jeremyroman
reviewed
Aug 9, 2024
Member
|
Since this is a normative change could you please not omit the PR template? |
zcorpan
reviewed
Aug 12, 2024
Collaborator
Author
Done. |
domenic
approved these changes
Aug 14, 2024
Member
domenic
left a comment
There was a problem hiding this comment.
I pushed a tweak to nest the reporting under the "catch", since I didn't want to make us do too much more back-and-forth for this. Thanks very much!
Collaborator
Author
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #10527 for context, but no browser currently reports exceptions for this case, and doing so might pose an XSS risk. Correct the spec text accordingly.
Closes #10527
Not needed I believe - this behavior isn't documented on MDN anyway
/parsing.html ( diff )