Skip to content

Point default referrer policy to a constant defined in RP spec#1066

Merged
annevk merged 1 commit into
whatwg:masterfrom
krgovind:master
Nov 30, 2020
Merged

Point default referrer policy to a constant defined in RP spec#1066
annevk merged 1 commit into
whatwg:masterfrom
krgovind:master

Conversation

@krgovind

@krgovind krgovind commented Aug 3, 2020

Copy link
Copy Markdown
Contributor

This is a re-do of #952 started by @mikewest since I am taking over the relevant spec updates.

This spec will now point to a constant defined in w3c/webappsec-referrer-policy/pull/142 as the default referrer policy.


Preview | Diff

@annevk

annevk commented Aug 4, 2020

Copy link
Copy Markdown
Member

Thank you! You'll need to make your membership of the googlers organization public.

@krgovind

krgovind commented Aug 4, 2020

Copy link
Copy Markdown
Contributor Author

Thank you! You'll need to make your membership of the googlers organization public.

Done! It's my first time contributing to specs, so still discovering all the boxes I need to check off. :)

@annevk

annevk commented Aug 5, 2020

Copy link
Copy Markdown
Member

Great! (Landing this is blocked on w3c/webappsec-referrer-policy#142.)

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Aug 6, 2020

@domfarolino domfarolino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And as Anne said, I think we'll hold off on merging this until:

  • Referrer Policy spec changes lands
  • WPTs are ready to land

@krgovind

Copy link
Copy Markdown
Contributor Author

Great! (Landing this is blocked on w3c/webappsec-referrer-policy#142.)

w3c/webappsec-referrer-policy#142 has now landed. Could we merge this please?

@annevk

annevk commented Nov 30, 2020

Copy link
Copy Markdown
Member

From the Referrer Policy issue:

Is there a Safari bug? At least I got the impression they did not ship a strict superset of this.

@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Nov 30, 2020
@annevk annevk merged commit eda4152 into whatwg:master Nov 30, 2020
@krgovind

Copy link
Copy Markdown
Contributor Author

Safari bug is here.

@annevk

annevk commented Nov 30, 2020

Copy link
Copy Markdown
Member

Thanks @krgovind! Glad this is mostly wrapped up now. I rebased the HTML PR and hopefully @domenic will have time for that soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants