Skip to content

Define "Request URL serialization for reporting"#1028

Merged
annevk merged 4 commits intomasterfrom
yhirano/request-url-for-reporting
Jun 2, 2020
Merged

Define "Request URL serialization for reporting"#1028
annevk merged 4 commits intomasterfrom
yhirano/request-url-for-reporting

Conversation

@yutakahirano
Copy link
Member

@yutakahirano yutakahirano commented May 29, 2020

This is a preliminary change for COEP merging to the HTML and fetch specs.
We will use the serialization multiple times both in the HTML spec and
the fetch spec, so defining the operation here will be benefitial.

There's no behavior change.


💥 Error: 400 Bad Request 💥

PR Preview failed to build. (Last tried on Jun 2, 2020, 8:25 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@yutakahirano
Copy link
Member Author

This addresses whatwg/html#5454 (comment) made by @domenic.

@yutakahirano yutakahirano marked this pull request as ready for review May 29, 2020 09:07
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea!

I wonder if this obsoletes the need for whatwg/url#476 @mikewest? If it doesn't I guess we identified at least one other user of that algorithm.

This is a preliminary change for COEP merging to HTML and fetch specs.
We will use the serialization multiple times both in the HTML spec and
the fetch spec, so defining the operation here will be benefitial.
@yutakahirano yutakahirano force-pushed the yhirano/request-url-for-reporting branch from 8553392 to ec9091b Compare May 29, 2020 10:15
@yutakahirano yutakahirano mentioned this pull request May 29, 2020
3 tasks
@yutakahirano
Copy link
Member Author

Anne, do you have further comments/suggestions?

@annevk annevk merged commit 17723c6 into master Jun 2, 2020
@annevk annevk deleted the yhirano/request-url-for-reporting branch June 2, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants