.gitignore (1)

143-145: Context folder now ignored — confirm no runtime dependency and mirror in container ignores

Sensible to keep ephemeral correlation/context assets out of VCS, Sir. Please verify nothing in context/ is required at build/test time, and consider adding the same pattern to .dockerignore (and any deployment ignore lists) to keep images lean.

src/config/env.ts (1)

8-29: Solid runtime validation — extract and reuse reserved set for consistency and type-safety

Nicely fail-fast and normalized to lowercase. To avoid drift across files and enable better hinting, hoist the reserved set and reuse it.

Apply:

+// Centralize reserved platforms for reuse across codebase and docs
+export const RESERVED_TARGET_PLATFORMS = ['dashboard', 'unknown', 'buffered'] as const;
+
 function validateTargetPlatform(platform: string | undefined): string {
@@
-    const cleanPlatform = platform.trim().toLowerCase(); // Convert to lowercase for canonical format
-    const reservedPlatforms = ['dashboard', 'unknown', 'buffered'];
+    const cleanPlatform = platform.trim().toLowerCase(); // Convert to lowercase for canonical format
+    const reservedPlatforms = RESERVED_TARGET_PLATFORMS;

.github/chatmodes/WG Code Builder.chatmode.md (1)

80-80: Fix markdownlint MD036: render the quote as a blockquote, not emphasized text

A blockquote reads better and silences lint.

Apply:

-*\"The expert in anything was once a beginner who refused to give up.\" - Helen Hayes*
+> "The expert in anything was once a beginner who refused to give up." — Helen Hayes

src/types/index.ts (4)

56-57: PlatformSource typing: literal union redundancy and intent clarity

string | 'buffered' is effectively just string. If you want to call out reserved sources explicitly, centralize and reuse a reserved set; otherwise, keep it purely string for clarity.

Option A (centralize reserved values):

+export const RESERVED_PLATFORM_VALUES = ['dashboard', 'unknown', 'buffered'] as const;
+export type ReservedPlatform = typeof RESERVED_PLATFORM_VALUES[number];
-export type PlatformSource = string | 'buffered';
+export type PlatformSource = string | ReservedPlatform;

---

129-134: Use PlatformSource for sourcePlatform

Tighten the type to align with the rest of the model.

Apply:

-export interface FileAttachmentCorrelationEntry {
-  sourcePlatform: string;
+export interface FileAttachmentCorrelationEntry {
+  sourcePlatform: PlatformSource;
   messageEventId: string;
   timestamp: number;
 }

---

136-146: Timer type compatibility: prefer ReturnType over NodeJS.Timeout

Keeps types portable between Node/DOM typing sets and avoids ambient Node dependency leaks.

Apply:

 export interface FileAttachmentBufferedEvent {
   eventData: UnthreadWebhookEvent;
   correlationKey: string;
   bufferedAt: number;
-  timeoutId: NodeJS.Timeout;
+  timeoutId: ReturnType<typeof setTimeout>;
 }
@@
 export interface FileAttachmentBufferedEvents {
   events: FileAttachmentBufferedEvent[];
-  sharedTimeoutId: NodeJS.Timeout;
+  sharedTimeoutId: ReturnType<typeof setTimeout>;
 }

---

67-81: AttachmentMetadata naming clarity and forward-compat

Looks good. Minor clarity: types can be misread as TypeScript types. Consider mimeTypes, keeping types as a deprecated alias for a release for non-breaking change.

Apply:

 export interface AttachmentMetadata {
   /** True if data.files array exists and has content, false otherwise */
   hasFiles: boolean;
   /** Number of files in data.files array (0 when hasFiles is false) */
   fileCount: number;
   /** Total size in bytes of all files combined (0 when hasFiles is false) */
   totalSize: number;
-  /** Unique MIME types of all files (empty array when hasFiles is false) */
-  types: string[];
+  /** Unique MIME types of all files (empty array when hasFiles is false) */
+  mimeTypes: string[];
+  /** Deprecated: use mimeTypes */
+  types?: string[];
   /** Names of all files (empty array when hasFiles is false) */
   names: string[];
 }

Follow-up: map types -> mimeTypes at construction time to preserve backward compatibility.

README.md (1)

317-338: Encoding artefacts detected in headings

Headings show the replacement character � before “Recent Updates” and “🙏 Sponsor”. Please replace with the intended emoji or remove to keep the README pristine.

src/utils/fileAttachmentCorrelation.ts (3)

15-19: Consider externalising TTL constants for flexibility

Sir, your hard-coded timing values (TTL, buffer timeout, cleanup interval) lock behaviour at compile-time. Surfacing them as constructor parameters or env-driven config would let operations tune performance without a code deploy.

---

200-249: Redundant clearTimeout calls inflate overhead

Inside the existing-buffer branch, you clear existing.sharedTimeoutId at Line 202, and then immediately clear it again at Line 240 after potential duplicates handling. The first invalidation is sufficient; the second is superfluous and costs an extra native call.

-      // Clear existing timeout
-      clearTimeout(existing.sharedTimeoutId);
...
-      // Clear existing timeout before creating new one
-      if (existing.sharedTimeoutId) {
-        clearTimeout(existing.sharedTimeoutId);
-      }

---

223-228: Avoid null as any to keep type safety immaculate

Setting timeoutId: null as any bypasses the compiler. Declaring timeoutId?: NodeJS.Timeout (optional) or initialising with undefined keeps typings pure and removes the unchecked cast.

Also applies to: 252-257

src/services/webhookService.ts (1)

75-98: Attachments field may be undefined downstream

transformEvent only attaches message.attachments when hasFiles is true. Consumers expecting the key to exist will need extra guards. Consider always emitting the object with hasFiles flag to simplify parsing on the other end.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: warengonzaga
PR: wgtechlabs/unthread-webhook-server#7
File: README.md:53-58
Timestamp: 2025-06-22T15:52:25.095Z
Learning: In the unthread-webhook-server repository README.md, the Railway deploy link URL uses "unthread-webhook-ser" instead of the full "unthread-webhook-server" - this is intentional shortening, not a typo.

Learnt from: warengonzaga
PR: wgtechlabs/unthread-webhook-server#7
File: README.md:53-58
Timestamp: 2025-06-22T15:52:25.095Z
Learning: In the unthread-webhook-server repository README.md, the Railway deploy link URL uses "unthread-webhook-ser" instead of the full "unthread-webhook-server" - this is intentional shortening, not a typo.