Merged
Conversation
Owner
|
Hi guys, ti would be great if you could write some tests and add some examples to the documentation (README) for your changes. |
Contributor
|
I went ahead and merged this in to my changes, and added some documentation and basic unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Wesley,
First of all, let me congratuate for your Node-Genx project, we found it very useful.
The JayData team has forked your https://github.com/wezm/node-genx repo to add new features for our developments.
We have successfully added inline XML output feature to your library, and hope you will find it beneficial to your users. Our plan is to deliver a product in a few days –using this new feature – and we would be glad to use a new official release of your library published by you.
Please contact us in e-mail (community@jaystack.com) and share your feedback and if it is likely to happen that you release a new NPM package soon.
Thank you for all your efforts in advance.
Bye,
JayData dev team