fix(vue): add eventemitter3 to optimizeDeps for Nuxt compatibility#5028
Merged
fix(vue): add eventemitter3 to optimizeDeps for Nuxt compatibility#5028
Conversation
|
@faizkhairi is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 3865b69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Thanks @tmm for the imports fix and etc! Happy to be able help and contribute for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Nuxt auto-import failures caused by eventemitter3 (a CJS dependency of @wagmi/core) not being pre-bundled by Vite when there is no explicit import statement in user code.
When using @wagmi/vue/nuxt auto-imports, the browser throws:
Fix
Adds eventemitter3 to Vite's optimizeDeps.include via the vite:extendConfig hook in the Nuxt module setup. This ensures Vite pre-bundles the CJS package into an ESM-compatible format, matching the approach recommended by @danielroe in #3977 (comment).
Changes
Fixes #3977