fix: pass chainId to Tempo webAuthn key authorization#5023
Closed
fix: pass chainId to Tempo webAuthn key authorization#5023
Conversation
The webAuthn connector was not forwarding chainId when provisioning access keys, which breaks newer viem Tempo runtimes. Add a focused regression test for the sign-up provisioning path.
|
@arjunblj is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
Member
|
Closing in favor of #5024 Added you as co-author so you still get commit credit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a
wagmi/viemcompatibility issue in the TempowebAuthnconnector.We hit it in production on
wagmi@3.5.0withviem@2.47.5: Tempo WebAuthn sign-up withgrantAccessKeyenabled calledsignKeyAuthorization()without forwardingchainId, and newerviemTempo runtimes then threwCannot convert undefined to a BigInt.This passes
chainIdthrough during access-key provisioning and adds a focused regression test.