switch chain on connect in walletconnect connector#4691
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c0a9149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
I forked this connector with these changes and I was able to connect without issues! |
…/walletconnect-switchchain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that connecting Rainbow wallet app via WalletConnect would fail for my local app when attempting to use the connected account, because Rainbow doesn't support adding networks. This appears to happen because the
walletConnectconnector callsswitchChaininsidegetProvider, whereas other connectors appear to do their chain check andswitchChaincall inside ofconnect:wagmi/packages/core/src/connectors/injected.ts
Line 174 in f5b717c
wagmi/packages/connectors/src/coinbaseWallet.ts
Line 132 in f5b717c
wagmi/packages/connectors/src/metaMask.ts
Line 147 in f5b717c
For my app, I've set
initialChainIdto0to kinda bypass the chain switching step here, which works because my app only needs signatures from the connected wallet, regardless of the chain it's connected to.I'm not really sure how to go about testing this change, but this PR aligns the switch chain logic across all connectors.