fix(tempo): bump gas for access key + fee payer transactions#4450
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d479d-73ca-711b-9007-a0ebe7df0cd1 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: e12ae11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6817b58 to
7f1222c
Compare
commit: |
7f1222c to
d18b3ca
Compare
d18b3ca to
2bfda55
Compare
…sactions Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d514e-7cba-74df-90ee-9b066be51393
f5f5336 to
0661677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponsored transactions from Tempo Wallet (P256 access key) fail with out-of-gas on the second transaction.
eth_fillTransactionestimates gas using a secp256k1 dummy signature andfeePayerSignature: null. The actual signed transaction has a larger keychain P256 envelope (~151 bytes) and a real fee payer signature (65 bytes), costing ~8k more intrinsic gas.The existing +20k gas bump only applied to
webAuthnkey authorizations. This adds a +10k bump foraccessKeyaccounts with a fee payer.Node-side fix: tempoxyz/tempo#3446