feat(tempo): add TIP-1004 permit functions to tip20 ABI#4442
Merged
Conversation
Adds permit, nonces, and DOMAIN_SEPARATOR to the tip20 ABI definition, along with PermitExpired and InvalidSignature errors. These were added to the Tempo node as part of TIP-1004 (EIP-2612 permit support) but the ABI in viem was not regenerated. Co-authored-by: Liam Horne <1933029+snario@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4e48-9e9b-705a-a49e-7a3eea84702b
|
@decofe is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 2544d2e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Liam Horne <1933029+snario@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d4e48-9e9b-705a-a49e-7a3eea84702b
Contributor
Author
|
Once this is merged and published, tempoxyz/tempo-apps#807 removes the short-term workaround and bumps viem to |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
permit,nonces, andDOMAIN_SEPARATORto thetip20ABI, along withPermitExpiredandInvalidSignatureerrors.These were added to the Tempo node's
ITIP20interface as part of TIP-1004 (EIP-2612 permit support) but the viem ABI was not regenerated. Without these, the explorer can't decode permit-related calls/events, and SDK users can't callpermitvia viem.Short-term explorer workaround: tempoxyz/tempo-apps#806
Verified on mainnet:
DOMAIN_SEPARATOR()returns valid bytes32nonces(address)returns uint256permit(...)is callable (reverts withInvalidSignaturefor bad sigs, confirming the function exists)Prompted by: Liam
Co-Authored-By: Liam Horne 1933029+snario@users.noreply.github.com