Skip to content

Commit 295bd73

Browse files
committed
fix: resolves #4218, #4219
1 parent ea0b9d4 commit 295bd73

4 files changed

Lines changed: 10 additions & 9 deletions

File tree

.changeset/puny-rocks-see.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"viem": patch
3+
---
4+
5+
Fixed sendTransactionSync timeout propagation.

src/actions/wallet/sendRawTransactionSync.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,7 @@ import type { Chain } from '../../types/chain.js'
66
import type { TransactionSerializedGeneric } from '../../types/transaction.js'
77
import type { RequestErrorType } from '../../utils/buildRequest.js'
88
import { formatTransactionReceipt } from '../../utils/formatters/transactionReceipt.js'
9-
import {
10-
type FormattedTransactionReceipt,
11-
numberToHex,
12-
} from '../../utils/index.js'
9+
import type { FormattedTransactionReceipt } from '../../utils/index.js'
1310

1411
export type SendRawTransactionSyncParameters = {
1512
/** The signed serialized transaction. */
@@ -62,9 +59,7 @@ export async function sendRawTransactionSync<chain extends Chain | undefined>(
6259
const receipt = await client.request(
6360
{
6461
method: 'eth_sendRawTransactionSync',
65-
params: timeout
66-
? [serializedTransaction, numberToHex(timeout)]
67-
: [serializedTransaction],
62+
params: timeout ? [serializedTransaction, timeout] : [serializedTransaction],
6863
},
6964
{ retryCount: 0 },
7065
)

src/actions/wallet/sendTransactionSync.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ export async function sendTransactionSync<
375375
)({
376376
serializedTransaction,
377377
throwOnReceiptRevert,
378+
timeout,
378379
})) as never
379380
}
380381

src/types/eip1193.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1206,7 +1206,7 @@ export type PublicRpcSchema = [
12061206
Method: 'eth_sendRawTransactionSync'
12071207
Parameters:
12081208
| [signedTransaction: Hex]
1209-
| [signedTransaction: Hex, timeout: Hex]
1209+
| [signedTransaction: Hex, timeout: number]
12101210
ReturnType: TransactionReceipt
12111211
},
12121212
/**
@@ -1778,7 +1778,7 @@ export type WalletRpcSchema = [
17781778
Method: 'eth_sendRawTransactionSync'
17791779
Parameters:
17801780
| [signedTransaction: Hex]
1781-
| [signedTransaction: Hex, timeout: Hex]
1781+
| [signedTransaction: Hex, timeout: number]
17821782
ReturnType: TransactionReceipt
17831783
},
17841784
/**

0 commit comments

Comments
 (0)