Merged
Conversation
d07423c to
fccbf4d
Compare
If values.yaml already exist in the chart the moment we call nelm chart init --ts, then there are no values.yaml generated and an image in the deployment becomes undefined:undefined. Fallback needed. Probably this: image: ($.Values.image?.repository ?? 'nginx') + ':' + ($.Values.image?.tag ?? 'latest') Nelm SDK npm package name is wrong both in package.json and src files generated by nelm chart init --ts --noEmit in scripts in package.json? Probably these scripts need revision Also instead of just `import` now use `import type` so if only types are used this package can be build without installing any packages, just with werf. Signed-off-by: Dmitry Bochkarev <dimabochkarev@gmail.com>
fccbf4d to
174c907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixes for issues with Typescript initialization mentioned in #547
Also instead of just
importnow useimport typeto mark explicitly only types areused this package can be build without installing any packages.