Skip to content

fix: WPS529 false positive#3634

Merged
sobolevn merged 2 commits intowemake-services:masterfrom
vldmrdev:3501-fix-wps529-false-positive
Apr 27, 2026
Merged

fix: WPS529 false positive#3634
sobolevn merged 2 commits intowemake-services:masterfrom
vldmrdev:3501-fix-wps529-false-positive

Conversation

@vldmrdev
Copy link
Copy Markdown
Contributor

@vldmrdev vldmrdev commented Apr 23, 2026

I have made things!

  1. Modified ImplicitDictGetVisitor._check_implicit_get and add _walk_body func, else exluded from check scope.
  2. Added negative test and test case for else

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #3501

🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3771f75) to head (ccf52e4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3634   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          369       369           
  Lines        12410     12421   +11     
  Branches       858       859    +1     
=========================================
+ Hits         12410     12421   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vldmrdev vldmrdev force-pushed the 3501-fix-wps529-false-positive branch from 295493d to e6f8b95 Compare April 23, 2026 22:54
Comment thread tests/test_visitors/test_ast/test_subscripts/test_implicit_get.py Outdated
Comment thread tests/test_visitors/test_ast/test_subscripts/test_implicit_get.py Outdated
Comment thread wemake_python_styleguide/visitors/ast/subscripts.py
Comment thread wemake_python_styleguide/visitors/ast/subscripts.py
@vldmrdev vldmrdev force-pushed the 3501-fix-wps529-false-positive branch from e6f8b95 to 844bfa7 Compare April 26, 2026 21:41
@vldmrdev vldmrdev force-pushed the 3501-fix-wps529-false-positive branch from 844bfa7 to 403b325 Compare April 26, 2026 21:45
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Comment thread wemake_python_styleguide/violations/refactoring.py Outdated
Comment thread wemake_python_styleguide/violations/refactoring.py Outdated
@sobolevn sobolevn merged commit 76860b9 into wemake-services:master Apr 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for WPS529

2 participants