Skip to content

fix: false positive WPS412, refs #3569#3571

Merged
sobolevn merged 3 commits intowemake-services:masterfrom
milssky:fix/issue-3569
Dec 11, 2025
Merged

fix: false positive WPS412, refs #3569#3571
sobolevn merged 3 commits intowemake-services:masterfrom
milssky:fix/issue-3569

Conversation

@milssky
Copy link
Copy Markdown
Contributor

@milssky milssky commented Dec 11, 2025

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #3569

🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f727869) to head (aa83233).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3571   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          369       369           
  Lines        12263     12265    +2     
  Branches       844       844           
=========================================
+ Hits         12263     12265    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGELOG.md Outdated
- Allows `__init__.py` files that consist only of imports, #3486
- Adds `--max-conditions` option, #3493
- Adds `--known-enum-bases` option to support custom enum-like base classes, #3513
- Fixes false positive `WPS412` with docstring and imports in `__init__.py` #3569
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go to WIP section.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn! I missed!

Comment thread CHANGELOG.md Outdated
- Adds `WPS481`: for statement not allowed in class and module scopes, #3520
- Allows `/` string in `WPS226`, #3554
- Adds `WPS365`: match statement can be simplified to `if`, #3520
- Fixes false positive `WPS412` with docstring and imports in `__init__.py` #3569
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should go to the "bugfixes" section 🌚️️

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌚️️

@sobolevn sobolevn merged commit 1b0de78 into wemake-services:master Dec 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive of WPS412

2 participants