feat: forbid confusing syntax (WPS364); add visitor and tests#3516
Merged
sobolevn merged 4 commits intowemake-services:masterfrom Aug 27, 2025
Merged
feat: forbid confusing syntax (WPS364); add visitor and tests#3516sobolevn merged 4 commits intowemake-services:masterfrom
sobolevn merged 4 commits intowemake-services:masterfrom
Conversation
sobolevn
reviewed
Aug 25, 2025
| my_print(3 / 3) | ||
| my_print('no zero division error') | ||
|
|
||
| # New violation example for WPS364: |
Member
There was a problem hiding this comment.
Suggested change
| # New violation example for WPS364: |
|
|
||
| """ | ||
|
|
||
| error_template = 'Found `not ... in ...`, use `not in`' |
Member
There was a problem hiding this comment.
Suggested change
| error_template = 'Found `not ... in ...`, use `not in`' | |
| error_template = 'Found legacy `not ... in`, use `... not in` instead' |
Comment on lines
+254
to
+260
| if isinstance(node.op, ast.Not) and isinstance( | ||
| node.operand, | ||
| ast.Compare, | ||
| ): | ||
| comp = node.operand | ||
| if len(comp.ops) == 1 and isinstance(comp.ops[0], ast.In): | ||
| self.add_violation(NotInWithUnaryOpViolation(node)) |
Member
There was a problem hiding this comment.
Suggested change
| if isinstance(node.op, ast.Not) and isinstance( | |
| node.operand, | |
| ast.Compare, | |
| ): | |
| comp = node.operand | |
| if len(comp.ops) == 1 and isinstance(comp.ops[0], ast.In): | |
| self.add_violation(NotInWithUnaryOpViolation(node)) | |
| def _check_legacy_not_int(self, node: ast.UnaryOp) -> None: | |
| if isinstance(node.op, ast.Not) and isinstance( | |
| node.operand, | |
| ast.Compare, | |
| ): | |
| comp = node.operand | |
| if len(comp.ops) == 1 and isinstance(comp.ops[0], ast.In): | |
| self.add_violation(NotInWithUnaryOpViolation(node)) |
and call this method in visit_UnaryOp
| """Forbids ``not a in b`` which should be written as ``a not in b``.""" | ||
|
|
||
| def visit_UnaryOp(self, node: ast.UnaryOp) -> None: | ||
| """Detects ``not (a in b)`` pattern syntactically. |
Member
There was a problem hiding this comment.
Suggested change
| """Detects ``not (a in b)`` pattern syntactically. | |
| """ | |
| Detects ``not (a in b)`` pattern syntactically. |
sobolevn
reviewed
Aug 27, 2025
| if len(comp.ops) == 1 and isinstance(comp.ops[0], ast.In): | ||
| self.add_violation(NotInWithUnaryOpViolation(node)) | ||
| self.generic_visit(node) | ||
| # Split condition to keep per-line Jones Complexity low (WPS221): |
Member
There was a problem hiding this comment.
Suggested change
| # Split condition to keep per-line Jones Complexity low (WPS221): |
Comment on lines
+265
to
+268
| if len(comp.ops) == 1: | ||
| first_op = comp.ops[0] | ||
| if isinstance(first_op, ast.In): | ||
| self.add_violation(NotInWithUnaryOpViolation(node)) |
Member
There was a problem hiding this comment.
Suggested change
| if len(comp.ops) == 1: | |
| first_op = comp.ops[0] | |
| if isinstance(first_op, ast.In): | |
| self.add_violation(NotInWithUnaryOpViolation(node)) | |
| if ( | |
| len(comp.ops) == 1 | |
| and isinstance(comp.ops[0], ast.In) | |
| ): | |
| self.add_violation(NotInWithUnaryOpViolation(node)) |
Comment on lines
259
to
263
| if isinstance(node.op, ast.Not) and isinstance( | ||
| node.operand, | ||
| ast.Compare, | ||
| ): | ||
| comp = node.operand |
Member
There was a problem hiding this comment.
Please, convert this to use an early return pattern.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3516 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 363 364 +1
Lines 12071 12106 +35
Branches 823 827 +4
=========================================
+ Hits 12071 12106 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forbid confusing
not a in b(WPS364)This PR forbids the confusing historical syntax "not a in b".
not a in band related formsAll tests pass locally with 100% coverage.
Rationale:
not a in bis parsed asnot (a in b), which many readambiguously. The explicit
a not in bis clearer and idiomatic.Checklist
CHANGELOG.mdRelated issues
#3509