WPS349 highlighting#3437
Merged
sobolevn merged 1 commit intowemake-services:masterfrom May 29, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3437 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 362 362
Lines 11968 11987 +19
Branches 818 821 +3
=========================================
+ Hits 11968 11987 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sobolevn
reviewed
May 27, 2025
5a92f9f to
176b920
Compare
sobolevn
reviewed
May 29, 2025
Member
sobolevn
left a comment
There was a problem hiding this comment.
On the other hand - why not? It is better to the user to see what index is wrong exactly. Please, add a test with 2 and 3 wrong indexes.
176b920 to
20243a8
Compare
Contributor
Author
|
that's exactly what my idea was to improve visibility)) Extra tests have been added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
WPS349RedundantSubscriptViolation highlighting: now a specific slice index is highlighted, not the entire slice;instead of
I find it more appropriate to specify which index contains the redundant grammar
Checklist
CHANGELOG.md