Skip to content

Fixes #3417 , #3420#3423

Merged
sobolevn merged 2 commits intowemake-services:masterfrom
MIXgleb:issue-3417,3420
May 20, 2025
Merged

Fixes #3417 , #3420#3423
sobolevn merged 2 commits intowemake-services:masterfrom
MIXgleb:issue-3417,3420

Conversation

@MIXgleb
Copy link
Copy Markdown
Contributor

@MIXgleb MIXgleb commented May 19, 2025

The clone of the PR #3419 with clean commits and fixes from the maintainers.

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Hi,

@MIXgleb MIXgleb force-pushed the issue-3417,3420 branch 2 times, most recently from 98421d2 to 03d574d Compare May 20, 2025 11:03
@MIXgleb
Copy link
Copy Markdown
Contributor Author

MIXgleb commented May 20, 2025

Added tests for full coverage

@MIXgleb MIXgleb force-pushed the issue-3417,3420 branch from ca0ca1a to 03d574d Compare May 20, 2025 11:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5461f84) to head (03d574d).
⚠️ Report is 74 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #3423   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          362       362           
  Lines        11945     11956   +11     
  Branches       817       817           
=========================================
+ Hits         11945     11956   +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sobolevn
sobolevn approved these changes May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit e477120 into wemake-services:master May 20, 2025
10 of 14 checks passed
@MIXgleb MIXgleb deleted the issue-3417,3420 branch May 20, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WPS466 NewStyledDecoratorViolation issue

2 participants

@MIXgleb @sobolevn