Forbid comments in f strings#3407
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3407 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 362 362
Lines 11933 11945 +12
Branches 816 817 +1
=========================================
+ Hits 11933 11945 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sobolevn
left a comment
There was a problem hiding this comment.
Please, make sure that this feature is only checked on version that support it. And add the same version info to violation docs.
Co-authored-by: sobolevn <mail@sobolevn.me>
| """ | ||
|
|
||
|
|
||
| multiline_fstring_with_comment = """ |
There was a problem hiding this comment.
Please, also test strings with ' and """
|
Thanks for the review! But I don't understand why CI is breaking? Am I missing something? |
|
Coverage on older python versions is not properly configured. |
|
The only thing left to do is to fix conditional coverage :) |
|
Use |
|
@sobolevn Thanks! |
sobolevn
left a comment
There was a problem hiding this comment.
Awesome, we are almost there!
|
|
||
| Example:: | ||
|
|
||
| # Correct: |
There was a problem hiding this comment.
Accidentally deleted while fixing conflicts )
| }'world" | ||
| """ | ||
|
|
||
| fstring_with_comment_in_docstring = ''' |
There was a problem hiding this comment.
please, add wrong examples for fr and rf cases with ' and " and ''' and """
|
|
||
| Example:: | ||
|
|
||
| # Correct: |
|
Thanks a lot, really helpul! |
I have made things!
Checklist
CHANGELOG.mdRelated issues
Closes #3404